Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves jpeg segments names from $GLOBALS to class static property #421

Conversation

micheleorselli
Copy link
Contributor

I encountered some problems using this library when running PHPUnit tests with backupGlobal enabled (or at least, that seems the cause). Since $GLOBALS is not used in this codebase apart from here, I refactored the array as a class property

@JamesHeinrich JamesHeinrich merged commit 940d50f into JamesHeinrich:master Sep 1, 2023
14 checks passed
@micheleorselli micheleorselli deleted the remove_global_in_favor_of_static_property branch September 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants