V1.1.52.dev (#142)

* Add v1.1.52, return sp_vec_value_t rather than a Map due to ASAN issues.

* Remove unnecessary alias

* Update sigstore

.github/workflows/wheels.yml

@@ -109,7 +109,7 @@ jobs:
         path: dist/
         merge-multiple: true
     - name: Sign the dists with Sigstore
-      uses: sigstore/gh-action-sigstore-python@v2.1.1
+      uses: sigstore/gh-action-sigstore-python@v3.0.0
       with:
         inputs: >-
           ./dist/*.tar.gz

adelie/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "1.1.51"
+__version__ = "1.1.52"
 
 # Set environment flags before loading adelie_core
 import os

adelie/src/include/adelie_core/solver/solver_base.hpp

@@ -157,7 +157,7 @@ inline void update_screen_derived_base(
 // Then, state.dual is going to be super dense and we have 100 rows of such dense vectors.
 // Nonetheless, it's still useful to have this for diagnostic purposes... maybe a flag to control whether this gets saved?
 template <class StateType, class VecIndexType, class VecValueType>
-inline auto sparsify_dual(
+inline typename StateType::sp_vec_value_t sparsify_dual(
     const StateType& state,
     VecIndexType& indices,
     VecValueType& values

adelie/src/include/adelie_core/solver/solver_gaussian_cov.hpp

@@ -211,7 +211,6 @@ inline void update_solutions(
     using state_t = std::decay_t<StateType>;
     using vec_index_t = typename state_t::vec_index_t;
     using vec_value_t = typename state_t::vec_value_t;
-    using sp_vec_value_t = typename state_t::sp_vec_value_t;
 
     auto& betas = state.betas;
     auto& duals = state.duals;
@@ -223,8 +222,7 @@ inline void update_solutions(
     vec_value_t dual_values;
 
     betas.emplace_back(std::move(state_gaussian_pin_cov.betas.back()));
-    sp_vec_value_t dual = sparsify_dual(state, dual_indices, dual_values);
-    duals.emplace_back(std::move(dual));
+    duals.emplace_back(sparsify_dual(state, dual_indices, dual_values));
     intercepts.emplace_back(0);
     lmdas.emplace_back(lmda);
 

adelie/src/include/adelie_core/solver/solver_gaussian_naive.hpp

@@ -186,7 +186,6 @@ void update_solutions(
     using state_t = std::decay_t<StateType>;
     using vec_index_t = typename state_t::vec_index_t;
     using vec_value_t = typename state_t::vec_value_t;
-    using sp_vec_value_t = typename state_t::sp_vec_value_t;
 
     const auto y_var = state.y_var;
     auto& betas = state.betas;
@@ -199,8 +198,7 @@ void update_solutions(
     vec_value_t dual_values;
 
     betas.emplace_back(std::move(state_gaussian_pin_naive.betas.back()));
-    sp_vec_value_t dual = sparsify_dual(state, dual_indices, dual_values);
-    duals.emplace_back(std::move(dual));
+    duals.emplace_back(sparsify_dual(state, dual_indices, dual_values));
     intercepts.emplace_back(state_gaussian_pin_naive.intercepts.back());
     lmdas.emplace_back(lmda);
 

adelie/src/include/adelie_core/solver/solver_glm_naive.hpp

@@ -132,7 +132,6 @@ void update_solutions(
     using state_t = std::decay_t<StateType>;
     using vec_index_t = typename state_t::vec_index_t;
     using vec_value_t = typename state_t::vec_value_t;
-    using sp_vec_value_t = typename state_t::sp_vec_value_t;
 
     const auto loss_null = state.loss_null;
     const auto loss_full = state.loss_full;
@@ -147,8 +146,7 @@ void update_solutions(
     vec_value_t dual_values;
 
     betas.emplace_back(std::move(state_gaussian_pin_naive.betas.back()));
-    sp_vec_value_t dual = sparsify_dual(state, dual_indices, dual_values);
-    duals.emplace_back(std::move(dual));
+    duals.emplace_back(sparsify_dual(state, dual_indices, dual_values));
     intercepts.emplace_back(state_gaussian_pin_naive.intercepts.back());
     lmdas.emplace_back(lmda);