-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/point redesign #334
base: main
Are you sure you want to change the base?
Conversation
…2, but now produces wrong fit result?
self.profile = ( | ||
tracer.extract_profile(profile_name=name) if profile is None else profile | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.profile = profile or tracer.extract_profile(profile_name=name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extract_profile stuff looks a bit whacky to me
data_position: np.array, | ||
model_position: np.array, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np.ndarray
In order to help @jhod0 begin implementing new point source function, I have done a redesign and refactor of the
point
module.This does the following:
Fit
object.FitPoint
hierarchy to be clearer.I am not overly keen on the design of the
point/fit
package yet, with inheritance used a lot and quite confusing. But I don't have the capacity for a full redesign yet, and think we should wait until everything works with JAX before moving more stuff around.The merit of this design is that it mirrors other
Fit
objects throughout PyAutoLens, which is important for using functionality like the aggregator. It also means the API when you have a fit, e.g. after a model-fit, is quite clear and easy to use and contains everything:This should help us get started.