Skip to content

Commit

Permalink
Reworked borders (#1261)
Browse files Browse the repository at this point in the history
* Added ONLYOFFICE as an option

Though, xlsx$open() cannot be invoked, see: https://forum.onlyoffice.com/t/invoking-opening-an-xlsx-file-from-tmp-folder-does-not-succeed/11339

* Restructured add_border

It might bring some performance to this function to reduce the calls to create_border, determining style names and dimensions.

* ONLYOFFICE does not work :(

* [borders] fix lintr and a copy & paste mistake

* Added ONLYOFFICE support

When using ONLYOFFICE installed via snap please set TMPDIR to other locations within your .Renviron than /tmp since snap packages seem to be unable to access /tmp if you want to use wb$open(). Make sure to restart R/RStudio after making changes to .Renviron!

* [misc] fix lintr

* [misc] update NEWS, AUTHORS and WORDLIST
  • Loading branch information
pteridin authored Feb 11, 2025
1 parent 1423647 commit 93b7fcf
Show file tree
Hide file tree
Showing 6 changed files with 234 additions and 233 deletions.
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

* It is now possible to create shapes using `create_shape()`. [1231](https://github.com/JanMarvin/openxlsx2/pull/1231)
* Various input checks were added to the style helpers
* `write_xlsx()` now accepts `wb_set_base_font()` arguments to set the base font (size, color, name) for the entire workbook. [1262](https://github.com/JanMarvin/openxlsx2/pull/1262)
* `write_xlsx()` now accepts `wb_set_base_font()` arguments to set the base font (size, color, name) for the entire workbook. ([1262](https://github.com/JanMarvin/openxlsx2/pull/1262), @uhkeller)

## Fixes

Expand All @@ -18,6 +18,7 @@
* Update of internal pugixml library
* Switch to `f_attr` to handle more formula attributes
* Remove the use of `cc_out` when writing output files
* Refactoring of `wb_add_border()` (@pteridin)

## Breaking changes

Expand Down
Loading

0 comments on commit 93b7fcf

Please sign in to comment.