Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an employee id to jrc_author #120

Open
virginiascarlett opened this issue Nov 17, 2024 · 1 comment
Open

add an employee id to jrc_author #120

virginiascarlett opened this issue Nov 17, 2024 · 1 comment
Assignees

Comments

@virginiascarlett
Copy link
Collaborator

virginiascarlett commented Nov 17, 2024

This was inevitable... now I'm finding a use case for adding a single employee id to jrc_author, namely, if the confidence score is so low that name_match.py rules them out, but I happen to know who it is. Example: 10.1101/2024.06.30.601394. It doesn't catch Miguel, but that is the desired behavior.

Image

I could add this functionality to my name_match script, but it would probably make more sense to add it to your remove_jrc_author script, which would also need to be renamed.

If you need the user to specify the entire list with the new id included, to preserve order, that is very doable.

@virginiascarlett virginiascarlett changed the title append an employee id to jrc_author add an employee id to jrc_author Nov 17, 2024
@virginiascarlett
Copy link
Collaborator Author

Let's discuss this again. It may or may not be worth adding. My name match script does not add people to jrc_author if their location != Janelia. This leaves out some alumni we may wish to manually add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants