Test with base Fedora images

[JasonN3]

Fixes: #154

Summary by CodeRabbit

• Build Configuration
  • Enhanced GitHub Actions workflow build matrix configuration
  • Added support for more granular image repository and version selection
  • Introduced inclusion and exclusion rules for build images
  • Added specific configurations for Fedora OSTree desktop images

[JasonN3]

The test are still failing for ublue 41, but work for fedora 41
https://github.com/JasonN3/build-container-installer/actions/runs/12660064374

[JasonN3]

@coderabbitai review

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the .github/workflows/build_vars.yml file to restructure the BUILD_MATRIX configuration. The changes introduce a more sophisticated approach to defining build matrix parameters by implementing include and exclude arrays. This new structure allows for more granular control over image selection, specifically adding support for Fedora OSTree desktop images from the quay.io/fedora-ostree-desktops repository, including versions 40 and 41, while also providing mechanisms to exclude certain image configurations.

Changes

File	Change Summary
.github/workflows/build_vars.yml	- Replaced flat image_name list with structured include and exclude arrays - Added entries for Fedora OSTree desktop images (versions 40 and 41) - Introduced exclusion rules for specific image repositories and versions

Assessment against linked issues

Objective	Addressed	Explanation
Test with quay.io/fedora-ostree-desktops [#154]	✅

Possibly related PRs

• Block broken lorax versions #152: Workflow configuration modifications involving image_repo and image_name parameters, similar to the current PR's focus on image management

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

.github/workflows/build_vars.yml (1)

12-14: Optimize version array to match exclusion rules

Version "39" is listed in the versions array but later excluded for fedora-ostree-desktops. This creates unnecessary matrix combinations. Consider removing version "39" from the array since it's not used.

 "version": [
-  "39",
   "40",
   "41"
 ],

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 362fea7 and 1165b96.

📒 Files selected for processing (1)

• .github/workflows/build_vars.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (2)

.github/workflows/build_vars.yml (2)

22-23: LGTM! Repository configuration aligns with PR objectives

The addition of quay.io/fedora-ostree-desktops enables testing with base Fedora images as intended.

---

35-39: Verify test failures with ublue 41 image

Based on the PR comments, tests are failing for the ublue 41 image but passing for fedora 41 (base-atomic). Let's verify the configuration differences.