notify clients when publisher stopped broadcasting #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my use case I'm using ngnix-rtmp as rtmp proxy. When rtmp publisher disconnects, ffmpeg rtmp subscribers hangs indefinitely, and manually closing ffmpeg causes file corruption. This pull request resolves this issue by notifying client on publish/unpublish so ffmpeg exits gracefully.
notify clients when publisher stopped broadcasting
|
Thanks for this! However, in your PR you have disabled HLS, HLS is a large part of what's used on this image, Please could you remove disabling HLS and then I can merge this in. |
add build arg to fix build issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case I'm using ngnix-rtmp as rtmp proxy.
When rtmp publisher disconnects, ffmpeg rtmp subscribers hangs indefinitely, and manually closing ffmpeg causes file corruption.
This pull request resolves this issue by notifying client on publish/unpublish and handle it accordingly so ffmpeg exits gracefully.