Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expression Evaluator and Script Watches to the debugger #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add Expression Evaluator and Script Watches to the debugger #1

wants to merge 10 commits into from

Commits on Apr 10, 2020

  1. Add Expression Evaluator and Script Watches to the debugger 

    Evaluator allows  expressions to be evaluated in the current stack frame.
Watches keep track of a list of expressions.
    @rxlecky
    rxlecky committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    8128112 View commit details
    Browse the repository at this point in the history

  2. Add null checks to _evaluate_watches 

    Game occasionally crashes on nullptr dereference in _evaluate_watches.
Add null checks to help discover the issue.
    @rxlecky
    rxlecky committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    6db0424 View commit details
    Browse the repository at this point in the history

  3. Implement autoload evaluation in evaluator 

    Evaluating in watches still crashes
    @rxlecky
    rxlecky committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    093a366 View commit details
    Browse the repository at this point in the history

  4. Move watches under the Debugger tab 

    Move watches next to the stack frames and the code stepping buttons
    @rxlecky
    rxlecky committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    5417332 View commit details
    Browse the repository at this point in the history

  5. Enabled text selection in the evaluator log

    @rxlecky
    rxlecky committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    00d26ee View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Fix crash when removing a watch 

    Fix #10
    @rxlecky
    rxlecky committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    c5ef765 View commit details
    Browse the repository at this point in the history

  2. Add support for autolaods in watches 

    Closes #8
    @rxlecky
    rxlecky committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    e2147e4 View commit details
    Browse the repository at this point in the history

  3. Fix crash on non-existent member variable in watches 

    Fix #11
    @rxlecky
    rxlecky committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    d8651a3 View commit details
    Browse the repository at this point in the history

  4. Fix local and member vars not getting recognized 

    Fix #9
    @rxlecky
    rxlecky committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    92387c4 View commit details
    Browse the repository at this point in the history

  5. Fix crash when calling custom function in watches 

    Replaced evaluete_watches mutex with atomic counter to prevent infinite
recursion that caused this crash. Also moved all locking from
_evaluate_watches to the inlined evaluate_watches, making _evaluate_watches
thread unsafe.

Fix #12
    @rxlecky
    rxlecky committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    d583c8b View commit details
    Browse the repository at this point in the history