Serguei

[SergueiFedorov]

A lot of code clean up. I figure I am so far ahead in commits that I might as well push what I have back to you.

One thing to note:

I removed the build events because I couldn't get the program to run with them.

A lot of the code has been moved around and I reduced a lot of the code redundancies in places. A lot of this stuff can be wrapped into neatly packaged classes which at this point is the end goal. It seems like a lot of code got compounded as the feature list grew and it has become a little overwhelming. It should become a lot more maintainable as the cleanup processes continues.

[Jays2Kings]

That looks great, very nice job, however I'd have to merge this one my one as I've reoranized most of DS4Windows, but haven't adde dit to github yet.

[SergueiFedorov]

There is a lot stuff I've reorganized in DS4Control and DS4Library. If you
haven't touched those you could merge the changes without it affecting your
version. I have also pushed a lot of code into the UIOptionUtilities static
class. I can just run through your version once it's up and see if anything
is still useful in the utility class (a lot of it is just wrapped redundant
logic)

On Sun, Feb 8, 2015 at 1:42 PM, Jays2Kings [email protected] wrote:

That looks great, very nice job, however I'd have to merge this one my one
as I've reoranized most of DS4Windows, but haven't adde dit to github yet.

—
Reply to this email directly or view it on GitHub
#7 (comment).

[Jays2Kings]

I've added my newest version to github, like I said I'll try to merge what I can myself, but like I said I'm reorganized it into one project.

[SergueiFedorov]

Let me know when these changes are merged in so I can push the changes to my fork (regardless of how much you end up merging).

[SergueiFedorov]

I totally screwed that up. Sorry, I hit the wrong button

[SalahAdDin]

👍

[DerekTurtleRoe]

@SergueiFedorov What is the status of this?

[andersfischernielsen]

@SergueiFedorov You could also just create your own fork, and then people can use/fix issues in that. Then these changes will at least be used for something. :)
I don't know if the changes can't be applied now due to changes in the main project, though.

[DerekTurtleRoe]

@SergueiFedorov @Jays2Kings Does anybody know the status of this? Just curious.

[SergueiFedorov]

@vgturtle127 it seems that the pull request is very stale and the upstream codebase has deviated too much. I might take another swing at cleaning this project up a bit if I have time.

[DerekTurtleRoe]

@SergueiFedorov OK, thank you. Sorry for the double post, by the way. I just realized I did that. 😭

[MKH756]

👍