-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak in process.namespaces
#35
base: master
Are you sure you want to change the base?
Conversation
^ I believe the test runner is having issues. The same failures occur locally in |
This branch significantly reduces the memory creep I've been seeing with cls-hooked. |
@Jeff-Lewis Any chance this could be looked at? Btw, if you don't have time for the project anymore (which may be the case judging by amount of commits lately), I would be more than happy to volunteer to help maintain the project. |
Any updates?.. |
@Jeff-Lewis Any chance to take a look at this? In production : |
It looks like problem with leak is not in "process.namespaces" but in async_hook leaking. See #60 for details. |
@Jeff-Lewis ping( |
ayn update on this ? 👀 |
@ridakk It seems to be pretty abandoned. Either way, if you are on modern enough Node, migrating to AsyncLocalStorage is preferable. |
@kibertoad thx for the heads up, and yes we are on latest lts but our problem is Sequelize and it still depends on cls-hooked 😩 |
Numeric namespace identifiers are never removed from the global
process.namespaces
object:cls-hooked/context.js
Line 440 in 066c6c4
cls-hooked/context-legacy.js
Line 364 in 066c6c4