Fix #101

README.md

@@ -150,7 +150,16 @@ You can choose to use SQL instead by following this:
 
 ### Other Audit Log Configuration Options
 
-Backups and record duration can be configured in the `zSCSAuditLog.config` file.  It is recommended that you keep only what would be useful as due to the volume of data collected, these logs can get get large on a site with a high number of events if keeping logs for more than a week.
+Backups and record duration can be configured in the `zSCSAuditLog.config` file.  
+
+* keepRecords: Number of days to keep audit log records
+* keepBackups: Number of days to keep backup files (Lucene only)
+
+#### Lucene:
+It is recommended that you keep only what would be useful as due to the volume of data collected, these logs can get get large on a site with a high number of events if keeping logs for more than a week.
+
+#### SQL: 
+If using SQL mode, a lot of data can be stored before performance is impacted. Consider setting `keepRecords` to 180 (keep 180 days of data).
 
 Additional events can be tracked using additional onSaved nodes.  Note that new registered events need to have a unique id assigned to it and while it’s not required a unique color would be preferable from a user experience standpoint.
 

ScsAuditLog/Core/SqlAuditLog.cs

@@ -1,14 +1,15 @@
-using System;
+using Sidekick.AuditLog.Model;
+using Sidekick.AuditLog.Model.Interface;
+using Sidekick.Core.Services.Interface;
+using Sitecore.Data.Items;
+using System;
 using System.Collections.Generic;
 using System.Configuration;
 using System.Data.Linq;
 using System.Dynamic;
 using System.Linq;
 using System.Text;
-using Sidekick.AuditLog.Model;
-using Sidekick.AuditLog.Model.Interface;
-using Sidekick.Core.Services.Interface;
-using Sitecore.Data.Items;
+using System.Threading.Tasks;
 
 namespace Sidekick.AuditLog.Core
 {
@@ -28,6 +29,11 @@ public SqlAuditLog(int daysToKeepLog, int daysToKeepRecords, bool logAnonymousEv
 			_logDays = daysToKeepLog;
 			_recordDays = daysToKeepRecords;
 			_logAnonymousEvents = logAnonymousEvents;
+
+			Task.Run(() =>
+			{
+				CleanupOldData();
+			});
 		}
 
 		public IEnumerable<KeyValuePair<string, int>> AutoComplete(string text, string start, string end, List<object> eventTypes)
@@ -272,6 +278,18 @@ public int RebuildLogStatus()
 			return -1;
 		}
 
+		private void CleanupOldData()
+		{
+			using (var db = new SqlAuditLogDataContext())
+			{
+				var dateCutoff = DateTime.Now.AddDays(-_logDays);
+				db.ExecuteCommand(
+				"DELETE FROM [dbo].[AuditEntry] WHERE [TimeStamp] < {0}",
+				dateCutoff
+				);
+			}
+		}
+
 		private string BuildArrayQuery(IEnumerable<object> terms, string key, Dictionary<string, bool> databases)
 		{
 			if (key == "event") key = "EventId";

ScsAuditLog/Pipelines/OnSave.cs

@@ -24,11 +24,13 @@ public override void Process(object sender, EventArgs e)
 					Field field = item.Fields[fieldChange.FieldID];
 					if (!field.Name.StartsWith("__") && fieldChange.OriginalValue != field.Value)
 					{
+						var originalValue = fieldChange.OriginalValue ?? string.Empty;
+						var newValue = field.Value ?? string.Empty;
 						flag = true;
 						sb.Append("<tr><td>");
 						sb.Append(Cleanse(field.Name));
 						sb.Append("</td><td>");
-						HtmlDiff.HtmlDiff diff = new HtmlDiff.HtmlDiff(HttpUtility.HtmlEncode(fieldChange.OriginalValue), HttpUtility.HtmlEncode(field.Value));
+						HtmlDiff.HtmlDiff diff = new HtmlDiff.HtmlDiff(HttpUtility.HtmlEncode(originalValue), HttpUtility.HtmlEncode(newValue));
 						sb.Append(diff.Build());
 						sb.Append("</td></tr>");
 					}