Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix <root/> entries that specify a database #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jermdavis
Copy link

A first pass at a fix for the issue raised in #97, addressing the ContentMigrator module and a few core bits.

I've tried to rework a collection of API calls and method signatures so that databases are passed about correctly. Which should allow syncing the core database to work. There are probably better (neater) fixes to some of these issues, but the changes in this PR has been done quickly to enable a colleague to get on with some work, rather than be the ideal fix.

It's not exhaustively tested. I've done testing against a "localhost" root - which will successfully expand a core db tree, and preview/sync. (Obvs with no actual changes...) And my colleague who raised the original issue with me has also tested it between separate instances of his solution, and says that appears to be working similarly.

I wasn't able to make the unit tests run correctly in the v1.7 codebase (I get ~50 failed tests with the unchanged code) so I've not put effort into ensuring the tests aren't affected by these changes. The tests compile - but I didn't have time to work out if these failures were because the tests are broken, or because I was doing this in Sitecore v10 and VS2022.

Shout if you need any other work/changes to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant