Test Env Components Refactor #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffThorslund
temporarily deployed
to
bent-shaft-m-refactor-ldskjgpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I started working from top to bottom.
I barely touched the
TestEnvironment.jsand its components. Basically, just moved menu to the toolbar. Did a little bit of destructuring and prettifying.Then I just changed the order of props in
Feature.jsjust to make it look good.The heavy work was done with actual features.
I trimmed the properties of
Line,EddyandHydraulicand destructured them in thePointandCubic. For example coordinates are sent to Point and Cubic in one line and then get destructured there.Also created utils for svg element properties.
Added some comments here and there.