Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues for ALERT AI #423

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Fix issues for ALERT AI #423

merged 6 commits into from
Jan 10, 2025

Conversation

mathieuouillon
Copy link
Collaborator

Summary of Changes:

  1. Fix the loading of the model that required to download the PyTorch dll. Done by adding some dependencies for DJL.
  2. Move AI model to etc/nnet/ALERT/ folder and change the way the path is get. Addresses issue: AHDC AI track finding network file location #404
  3. Encapsulate model preparation and loading into a dedicated class
  4. Fix what happens for hits at the min/max of the wireId range. Addresses issue: AHDC cleanups #405
  5. Create a specific comparator for the Hit class to enable sorting by phi, since we can't use the one in the Hit class.

@mathieuouillon
Fix DJL model loading error caused by missing PyTorch dependencies
b86a6cb 
This commit resolves an issue where DJL (Deep Java Library) attempts to download PyTorch dependencies during runtime. Added explicit dependency management for DJL version 0.30.0, including the following modules:
   - pytorch-native-cpu
   - pytorch-jni
   - pytorch-engine
@mathieuouillon
Move AI model from reconstruction/alert to etc/nnet.
2a30edd 
Use CLASResources class to get the path of the model.
@mathieuouillon
Refactor: Encapsulate model preparation and loading into a dedicated …
fe1b8c6 
…class

Moved the preparation of the model and loading logic into a specific class to encapsulate functionality and reduce the number of imports.
@mathieuouillon
Update the wires checked during pre-clustering to ensure the AI can h…
d2de369 
…andle cases at the border.
@mathieuouillon
Fix Math.atan2: Swap x and y components.
29e827a
@mathieuouillon
Create a separate comparator for Hit class to enable sorting by phi, …
399ff29 
…as it can't be done within the class itself.
This was linked to issues Jan 9, 2025
AHDC AI track finding network file location #404
Closed
AHDC cleanups #405
Closed
@baltzell baltzell merged commit 7ee2cce into JeffersonLab:development Jan 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baltzell baltzell baltzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AHDC cleanups AHDC AI track finding network file location
2 participants
@mathieuouillon @baltzell