Added more "clicks" to timestamp tolerance. #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 13, 2025 16:13
- Increased the openshift memory request to build coatjava modified: .gitlab-ci.yml
…/decode/CodaEventDecoder.java
…/decode/CodaEventDecoder.java
baltzell
previously approved these changes
Feb 18, 2025
|
Have we used 78 before in CLAS12? |
|
@baltzell, Sorry I should mention that 78 is the ATOF. |
Added comment for crate 78
|
Right, my concern is whether we've had a 78 in (production) data before. If not, we can do it like this at least temporarily. |
|
How about trigger on detector type instead crate number? It's easy, accessible from the same object, and avoid conflicts from reused crate numbers. We also need to change the variable names for clarity, e.g., "i0" which is probably more correctly "iMaster". |
|
use #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #475.
I just added the 5 clicks that Sergey mentioned. To do this right, we need to know if the detector is using a TI board or TIpcie card. But I have verified this works with a recent "fixed" run 20764 where I can see the CTOF reconstruction.
Tests: