TIBlobModule: Better comments & warning message about word4 type

JeffersonLab · Aug 31, 2023 · fd16e76 · fd16e76
1 parent 2903ebd
commit fd16e76
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/TIBlobModule.cxx b/src/TIBlobModule.cxx
@@ -341,7 +341,7 @@ UInt_t TIBlobModule::LoadBank( Decoder::THaSlotData* sldat,
   evtblk.push_back(p-evbuffer); // include block trailer
 
   // Verify block trailer
-  if( (*p & 0xFFC00000) != (BIT(31) | (1U << 27) | (fSlot & 0x1F) << 22) ) {
+  if( (*p & 0xFFC00000) != (BIT(31) | (kBlockTrailer << 27) | (fSlot & 0x1F) << 22) ) {
     cerr << Here(here) << "Warning: Missing block trailer" << endl;
   }
   UInt_t nwords_inblock = *p & 0x3FFFFF;
@@ -437,8 +437,12 @@ void TIBlobModule::Clear(const Option_t* opt)
 //_____________________________________________________________________________
 void TIBlobModule::SetWord4Type( UInt_t type )
 {
-  if( type != 0 && type != kCounterBits && type != kTriggerBits )
+  if( type != 0 && type != kCounterBits && type != kTriggerBits ) {
+    Warning( "TIBlobModule::SetWord4Type",
+             "Unsupported type for 3rd/4th data word: %u. "
+             "Check configuration string in crate map.", type);
     return;
+  }
   fWord4Type = type;
 }
 

diff --git a/src/TIBlobModule.h b/src/TIBlobModule.h
@@ -54,6 +54,8 @@ class TIBlobModule : public PipeliningModule {
    // bits or the trigger bit pattern word, but not both. This case cannot
    // be unambiguously decoded automatically.
    // Values can be 0 = automatic, kCounterBits, or kTriggerBits.
+   // If this data word represents counter bits, this flag should be set via
+   // a configuration string (see Init()).
    void SetWord4Type( UInt_t type );
 
 protected: