Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cython version #88

Closed
wants to merge 5 commits into from

Conversation

HaydenCaffrey
Copy link

@HaydenCaffrey HaydenCaffrey commented Jul 18, 2023

There is an error raising when installing pyworld through pip since July 17th, the error occurs because of the newly released cython, restricting the cython version to <=0.29.36 can help solve the error. Local test succeeded.

@@ -1,5 +1,5 @@
numpy
matplotlib
argparse
cython
cython<=0.29.36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require cython as runtime requirement?

@JeremyCCHsu
Copy link
Owner

It has nothing to do with Cython version. I've confirmed that.

@r9y9
Copy link
Contributor

r9y9 commented Jul 20, 2023

Hey @JeremyCCHsu, I see installation errors with Cython 3.0.0. How did you confirm that? In my case restricting cython version works okay r9y9/pysptk#96.

@JeremyCCHsu
Copy link
Owner

Hi @r9y9 . This comment has the hint-- numpy should be installed before cython. Thus the solution is simple: in pyproject.toml, numpy should be listed before cython, so I updated this on the master branch.

What I have problem with PYPI is Travis CI-- it failed to deploy due to some urllib3 v2.0 issue. I'll manually update PyPI when I'm not occupied.

Anyway, installing from current master is working.

conda create -yn testpw0720 python=3.10
pip cache purge

git clone https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder.git
cd Python-Wrapper-for-World-Vocoder
git submodule update --init

pip install .

For testing:

pip install matplotlib soundfile
cd demo
python demo.py

The culprit isn't Cython:

import pyworld
import cython
>>> cython.__version__
'3.0.0'

@JeremyCCHsu
Copy link
Owner

JeremyCCHsu commented Jul 21, 2023

My previous conjecture about the package order in pyproject.toml isn't the root cause, though the issue in pyworld is miraculously resolved now.

Something's definitely wrong in the installation pipeline, and Cython seems to be the victim. In the pysptk repo, I did cython _sptk.pyx with Cython version 3.0.0, and the resulting _sptk.c file looks good (40999 lines). Nonetheless, pip install . doesn't work for pysptk, resulting in _sptk.c with one single line saying:

#error Do not use this file, it is the result of a failed Cython compilation.

Anyways, the above are just some of my observations FYI, @r9y9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants