JBR-8235 AIOOBE from newByteChannel on empty path name

JetBrains · Feb 10, 2025 · f179770 · f179770
1 parent 12009ba
commit f179770
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java b/src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java
@@ -197,8 +197,9 @@ protected static FileDescriptor open(int dfd,
             if (flags.createNew) {
                 byte[] pathForSysCall = path.asByteArray();
 
-                // throw exception if file name is "." to avoid confusing error
-                if ((pathForSysCall[pathForSysCall.length-1] == '.') &&
+                // throw exception if file name is "." or "" to avoid confusing error
+                if ((pathForSysCall.length == 0) ||
+                    (pathForSysCall[pathForSysCall.length-1] == '.') &&
                     (pathForSysCall.length == 1 ||
                     (pathForSysCall[pathForSysCall.length-2] == '/')))
                 {

diff --git a/test/jdk/java/nio/file/Files/Misc.java b/test/jdk/java/nio/file/Files/Misc.java
@@ -30,16 +30,17 @@
  */
 
 import java.io.IOException;
-import java.io.File;
 import java.nio.file.FileAlreadyExistsException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
 import java.nio.file.attribute.AclEntry;
 import java.nio.file.attribute.AclEntryPermission;
 import java.nio.file.attribute.AclEntryType;
 import java.nio.file.attribute.AclFileAttributeView;
 import java.nio.file.attribute.DosFileAttributeView;
 import java.nio.file.attribute.UserPrincipal;
+import java.util.EnumSet;
 import java.util.List;
 import jdk.test.lib.Platform;
 
@@ -55,6 +56,7 @@ public static void main(String[] args) throws IOException {
             testIsSameFile(dir);
             testFileTypeMethods(dir);
             testAccessMethods(dir);
+            testEmptyPathForByteStream();
         } finally {
              TestUtil.removeAll(dir);
         }
@@ -363,6 +365,18 @@ static void testAccessMethods(Path tmpdir) throws IOException {
         }
     }
 
+    static void testEmptyPathForByteStream() throws IOException {
+        Path emptyPath = Path.of("");
+        try {
+            emptyPath.getFileSystem().provider()
+                    .newByteChannel(emptyPath, EnumSet.of(StandardOpenOption.WRITE, StandardOpenOption.CREATE_NEW))
+                    .close();
+            throw new RuntimeException("FileAlreadyExistsException was not thrown");
+        } catch (FileAlreadyExistsException e) {
+            // The expected behavior.
+        }
+    }
+
     static void assertTrue(boolean okay) {
         if (!okay)
             throw new RuntimeException("Assertion Failed");