Fix javadoc info generator array init printing #2845
+34
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing of array initializers in the javadoc info generator was wrong:
(multiple dimension expressions are comma-separated in the last [])
(dimension expressions are generally moved into the last [])
The problem stems from how the full expression is a combination of type information and dimension expressions. This patch doesn't use the generic type printing code but instead a mix of printing dimension expressions and type information.
Note
I initially wanted to include annotations on the dimensions too, but I noticed that IntelliJ generally seems to attach annotations in the wrong order to the dimensions of the type. I assume this should be addressed separately first.
(order of annotations is reversed - this problem remains as it is not caused by this part of the code)
One test needed to be adjusted because the formatting now wasn't stick together manually anymore. The visuals are equal though I think.