[JEWEL-495] Fix nested inlines in Markdown #2994
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly supporting nested inline styling in Markdown requires a lot of changes. Luckily, they're mostly internal, but they do require us to deprecate and hide the old APIs because the behaviour has changed.
How does this fix work? Essentially, we need a smarter way to merge the styling as we visit nodes:
smartMerge
algorithm, used in the default inline renderer, that works the way we'd expect it to for MarkdownIn addition to that: