Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: platform libraries update #4694

Merged
merged 7 commits into from
Feb 13, 2025
Merged

feat: platform libraries update #4694

merged 7 commits into from
Feb 13, 2025

Conversation

danil-pavlov
Copy link
Contributor

No description provided.

@danil-pavlov danil-pavlov marked this pull request as ready for review February 10, 2025 16:04
@danil-pavlov danil-pavlov requested a review from a team as a code owner February 10, 2025 16:04
daniCsorbaJB
daniCsorbaJB reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update, looks great! 🚀

I left a couple of suggestions, please let me know what you think

docs/topics/native/native-platform-libs.md Outdated
To provide access to user's native operating system services,
Kotlin/Native distribution includes a set of prebuilt libraries specific to
each target. We call them **Platform Libraries**.
To provide access to operating systems' native services, Kotlin/Native distribution includes a set of prebuilt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To provide access to operating systems' native services, Kotlin/Native distribution includes a set of prebuilt
To provide access to native services of operating system, the Kotlin/Native distribution includes a set of prebuilt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to avoid the operating systems' possessive plural

docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
docs/topics/native/native-platform-libs.md Outdated Show resolved Hide resolved
daniCsorbaJB
daniCsorbaJB approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates - LGTM 🚀

@danil-pavlov danil-pavlov merged commit f4ad60a into master Feb 13, 2025
4 checks passed
@danil-pavlov danil-pavlov deleted the platform-libs-upd branch February 13, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniCsorbaJB daniCsorbaJB daniCsorbaJB approved these changes

Assignees

@daniCsorbaJB daniCsorbaJB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danil-pavlov @daniCsorbaJB