Build Skia with Clang-CL #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alovchin91
commented
Feb 4, 2025
GitHub Actions seem to have a very long PATH variable. Without the delayed expansion, Debug builds for Windows arm64 are failing.
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
7c4610a to
8772c12
Compare
igordmn
approved these changes
Feb 7, 2025
igordmn
pushed a commit
to JetBrains/skiko
that referenced
this pull request
Feb 12, 2025
Official Skia documentation suggests that it's [_highly recommended_](https://skia.org/docs/user/build/#highly-recommended-build-with-clang-cl) to build Skia with Clang-CL on Windows, and that this dramatically improves Skia performance with Software rendering and in other areas. This corresponds with my experience, so here it is. Related Skia-pack PR: JetBrains/skia-pack#64 Prerequisite: #1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official Skia documentation suggests that it's highly recommended to build Skia with Clang-CL on Windows, and that this dramatically improves Skia performance with Software rendering and in other areas. This corresponds with my experience, so here it is.
Related PR for Skiko: JetBrains/skiko#1020