Skip to content

Commit

Permalink
test: add httproute-response-header-control for oauth2-proxy#863 (oau…
Browse files Browse the repository at this point in the history
  • Loading branch information
robynron authored Mar 26, 2024
1 parent 4d6aa25 commit 97cf58e
Show file tree
Hide file tree
Showing 3 changed files with 162 additions and 0 deletions.
93 changes: 93 additions & 0 deletions test/e2e/conformance/tests/httproute-response-header-control.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
// Copyright (c) 2023 Alibaba Group Holding Ltd.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package tests

import (
"testing"

"github.com/alibaba/higress/test/e2e/conformance/utils/http"
"github.com/alibaba/higress/test/e2e/conformance/utils/suite"
)

func init() {
Register(HTTPRouteResponseHeaderControl)
}

var HTTPRouteResponseHeaderControl = suite.ConformanceTest{
ShortName: "HTTPRouteResponseHeaderControl",
Description: "A single Ingress in the higress-conformance-infra namespace controls the response header.",
Manifests: []string{"tests/httproute-response-header-control.yaml"},
Features: []suite.SupportedFeature{suite.HTTPConformanceFeature},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
testcases := []http.Assertion{
{
Meta: http.AssertionMeta{
TestCaseName: "case 1: add one",
TargetBackend: "infra-backend-v1",
TargetNamespace: "higress-conformance-infra",
CompareTarget: http.CompareTargetResponse,
},

Request: http.AssertionRequest{
ActualRequest: http.Request{
Path: "/foo1",
Host: "foo.com",
},
},

Response: http.AssertionResponse{
ExpectedResponse: http.Response{
StatusCode: 200,
Headers: map[string]string{
"stage": "test",
},
},
},
},
{
Meta: http.AssertionMeta{
TestCaseName: "case 2: add more",
TargetBackend: "infra-backend-v1",
TargetNamespace: "higress-conformance-infra",
CompareTarget: http.CompareTargetResponse,
},

Request: http.AssertionRequest{
ActualRequest: http.Request{
Path: "/foo2",
Host: "foo.com",
},
},

Response: http.AssertionResponse{
ExpectedResponse: http.Response{
StatusCode: 200,
Headers: map[string]string{
"stage": "test",
"canary": "true",
"x-test": "higress; test=true",
"x-test2": "higress; test=false",
},
},
},
},
}
t.Run("Response header control", func(t *testing.T) {
for _, testcase := range testcases {
http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, suite.GatewayAddress, testcase)
}
})
},
}
59 changes: 59 additions & 0 deletions test/e2e/conformance/tests/httproute-response-header-control.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Copyright (c) 2023 Alibaba Group Holding Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
higress.io/response-header-control-add: stage test
name: httproute-response-header-control-add-one
namespace: higress-conformance-infra
spec:
ingressClassName: higress
rules:
- host: "foo.com"
http:
paths:
- pathType: Exact
path: "/foo1"
backend:
service:
name: infra-backend-v1
port:
number: 8080
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
annotations:
higress.io/response-header-control-add: |
stage test
canary true
x-test "higress; test=true"
'x-test2' "higress; test=false"
name: httproute-response-header-control-add-more
namespace: higress-conformance-infra
spec:
ingressClassName: higress
rules:
- host: "foo.com"
http:
paths:
- pathType: Exact
path: "/foo2"
backend:
service:
name: infra-backend-v1
port:
number: 8080
10 changes: 10 additions & 0 deletions test/e2e/conformance/utils/roundtripper/roundtripper.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,16 @@ func (d *DefaultRoundTripper) CaptureRoundTrip(request Request) (*CapturedReques
Path: redirectURL.Path,
}
}
if len(cReq.Namespace) > 0 {
if _, ok := cRes.Headers["Namespace"]; !ok {
cRes.Headers["Namespace"] = []string{cReq.Namespace}
}
}
if len(cReq.Pod) > 0 {
if _, ok := cRes.Headers["Pod"]; !ok {
cRes.Headers["Pod"] = []string{cReq.Pod}
}
}

return cReq, cRes, nil
}
Expand Down

0 comments on commit 97cf58e

Please sign in to comment.