Referencing Binary Format: Remove references to collections #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types with collections are a bit hairy, what if it's first read as Set but later we serialize the same thing as SortedSet? Can't reuse the original value but instead need a copy constructor, and that's a lot of effort to code
wjnicholson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BeanReferences increments counts for values that are collection types, when we never serialize references for collections.
Doesn't affect serialization massively, but without we could be using a smaller references array / more efficient reference numbers. e.g in the test example, previously the letters "A" and "B" used references 5 and 6, rather than the 1 and 2 that they should have been (as the most common item to be referenced).
Can't really change the code to reuse collections, as some types of collections are a bit hairy, what if it's first read as Set but later we serialize a SortedSet with the same elements? Can't reuse the original value but instead need a copy constructor, and that's a lot of effort to code.
If somebody really wanted that effect they could wrap the collection in an ImmutableBean and get the deduplication for free.