Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FPS camera movement bug #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dr-nyt
Copy link

@dr-nyt dr-nyt commented May 17, 2021

In chapter 1, the first exercise from section 10.10 asks to convert the camera to be a true fps camera, with no vertical movement. The original code simply sets the y axis of the position to 0 to block vertical movement, but there is a bug where if the player is looking directly up or down, the player will slow down to a halt because it is the vertical vector from the pitch is added to the position.

I fixed this by creating a new vector that only adds the yaw (horizontal) axis while leaving the y-axis to 0. Less computation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant