model.h & mesh.h merged to one file and optimized! #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the model.h file to also have the code from mesh.h and it is very fast this way... i have found that in my game engine i can easily load a sphere containing over 500.000 tris / polys and still run the engine fluently :) i have been able to add more and more of these spheres so now it is satisfying.
|
I appreciate the effort, but I'd rather keep them seperate for learning purposes, efficiency is not my main concern with regards to the tutorials (I'm also not sure whether you've seen such a performance boost as you talk about run-time performance, while the model.h and mesh.h are only relevant for the first time a model loads). I plan to re-work the model/mesh tutorials soon anyways, with a much more streamlined mesh interface. I'll keep the pull request open for people who are interested :) |
|
Yeah i actually thought it would probably not be the best solution for opengl beginners but i first thought of it after i had made the pull request :) but thanks for keeping it up ;-) i do appreciate it :) |
|
Not at all! Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the model.h file to also have the code from mesh.h and it
is very fast this way... i have found that in my game engine i can
easily load a sphere containing over 500.000 tris / polys and still run
the engine fluently :) i have been able to add more and more of these
spheres so now it is satisfying. i have been able to add up to 30 of these spheres depending on what shader i use :)