Version 5 #1057
Version 5 #1057
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -30,44 +30,31 @@ interface Props { | |||
| } | |||
|
|
|||
| export const HotkeysProvider = ({ initiallyActiveScopes = ['*'], children }: Props) => { | |||
| const [internalActiveScopes, setInternalActiveScopes] = useState( | |||
There was a problem hiding this comment.
Maybe we could have this state wrapped in a React Context to allow separating enableScope and disableScope, thus allowing us to avoid re-renders where we use them.
This is a very painful problem right now, we cannot call useHotkeysContext() without having re-renders because of enabledScopes changing and causing every component calling useHotkeysContext() to re-render, even if they don't care about this dependency and just want to enable/disable a scope.
There was a problem hiding this comment.
I would be glad to collaborate on this because we do an extensive usage of scopes at https://github.com/twentyhq/twenty and we have problems managing re-renders.
There was a problem hiding this comment.
I don't think I quite understand this issue. enableScope and disableScope are already decoupled.
enabledScopes is a state, so changing the value will retrigger depend components. I understand that this causes re renders when calling enableScope, but the only fix would be to have the enabledScopes in another context, which, API wise, seems weird.
Maybe I am missing something?
| @@ -1,3 +1,4 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
It might be a bit better to do a namespace import:
| import React from 'react' | |
| import * as React from 'react' |
Source: https://twitter.com/dan_abramov/status/1308739731551858689
This can make the difference in the future (React v19 or v20).
What is the current roadmap for v5? Just curious 🙃
There was a problem hiding this comment.
Thanks for the heads up. I have very limited time & motivation to improve on version 5. I hope this will change in the next months, but no promises.
# Conflicts: # documentation/yarn.lock # src/validators.ts # tests/useHotkeys.test.tsx
No description provided.