Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ZettaScript
Copy link

Currently, mumble-web is completely unusable with a screen reader. This commit improves semantic, accessibility for screen readers and keyboard navigation. (see WAI ARIA)

Further work is needed for:

  • activating buttons and rooms by keyboard
  • rooms accessibility
  • ARIA roles

I tried several things to add a keydown event (following the MDN) in the same way click is defined, but it doesn't work.

@ZettaScript ZettaScript marked this pull request as ready for review June 9, 2021 21:58
@zDEFz
Copy link

zDEFz commented Jun 14, 2021

Please add aria required true for mandatory fields like Server address.
But keep in mind if it isnt visually described, you may need to address this in another pull for a GUI change to make a red star or so.

@ZettaScript
Copy link
Author

Is aria-required needed when it is already required? As I understand it, the only difference between the two is that required prevents submitting the form and adds a "required" popup, while aria-required doesn't.

@zDEFz
Copy link

zDEFz commented Jun 14, 2021

aria-required is working across screenreaders, and even older ones.
My knowledge might be outdated by now, cause it appears that most screenreaders don't require aria-required instead of required for attribution anymore to read it out.

@ZettaScript
Copy link
Author

The official recommendations say to prefer semantic HTML, and to consider ARIA only if needed. In my experience, screen reader users don't have problems with required. I think the usecase of aria-required is very rare...

Copy link

@zDEFz zDEFz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants