Don't allow factors with <2 levels in regressions (jasp-stats#307)

* check factors in log reg * also for other regressions
JohnnyDoorn · May 7, 2024 · 929a7be · 929a7be
1 parent 9d0e651
commit 929a7be
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/R/generalizedlinearmodel.R b/R/generalizedlinearmodel.R
@@ -102,7 +102,14 @@ GeneralizedLinearModelInternal <- function(jaspResults, dataset = NULL, options,
                limits.min = 0,
                limits.max = Inf,
                exitAnalysisIfErrors = TRUE)
-
+
+  if (length(options$factors) != 0)
+    .hasErrors(dataset,
+               type = "factorLevels",
+               factorLevels.target  = options$factors,
+               factorLevels.amount  = '< 2',
+               exitAnalysisIfErrors = TRUE)
+
   if (options[["family"]] == "bernoulli") {
 
     if (length(levels(dataset[, options[["dependent"]]])) != 2)

diff --git a/R/regressionlinear.R b/R/regressionlinear.R
@@ -165,7 +165,12 @@ RegressionLinearInternal <- function(jaspResults, dataset = NULL, options) {
     .hasErrors(dataset, type = c("infinity", "limits", "observations"),
                all.target = options$weights, limits.min = 0, observations.amount = "< 2",
                exitAnalysisIfErrors = TRUE)
-
+    if (length(options$factors) != 0)
+      .hasErrors(dataset,
+                 type = "factorLevels",
+                 factorLevels.target  = options$factors,
+                 factorLevels.amount  = '< 2',
+                 exitAnalysisIfErrors = TRUE)
     covwt <- function(...) return(stats::cov.wt(..., wt = dataset[[.v(options[["weights"]])]])$cov)
     .hasErrors(dataset[, -which(colnames(dataset) %in% c(.v(options$weights)))],  type = "varCovData", varCovData.corFun = covwt,
                exitAnalysisIfErrors = TRUE)

diff --git a/R/regressionlogistic.R b/R/regressionlogistic.R
@@ -81,6 +81,12 @@ RegressionLogisticInternal <- function(jaspResults, dataset = NULL, options, ...
                all.target = options$covariates,
                observations.amount  = "< 2",
                exitAnalysisIfErrors = TRUE)
+  if (length(options$factors) != 0)
+    .hasErrors(dataset,
+               type = "factorLevels",
+               factorLevels.target  = options$factors,
+               factorLevels.amount  = '< 2',
+               exitAnalysisIfErrors = TRUE)
 }
 
 # Performance Diagnostics Container