Refactor for new solver

[checkraisefold]

Todo:

• Fixed autocompletion
• Fixed type registration and diagnostics
• Fixed inlay hints
• Fixed hover types/documentation
• Fixed sourcemap

Luau issues worked around:

• definitionModuleName is undefined for table type aliases luau-lang/luau#1441
• Magic functions are not called for overloaded function types (new solver) luau-lang/luau#1447

Blockers:
EDIT: Worked around with magic function
luau-lang/luau#1447 breaks the sourcemap WaitForChild overload registration and causes those tests to fail. I don't see a conceivable workaround for this for now because it causes a type checker error and there is no alternative to the magic function here

Original description:
The new solver has unified autocompletion and diagnostic types. In addition, the nonstrict mode has been significantly improved, meaning #83 has been completely sidestepped. As such, strict datamodel type flags should be ignored with the new solver enabled, and type registration should not occur on globalsForAutocomplete (because it is ignored by Luau).

In addition, loadDefinitionFile and by extension registerBuiltinGlobals, though still taking a typeCheckForAutocomplete argument, that argument no longer does anything within Luau internals, meaning the default to false is safe and it can be removed from explicit use.

Once the new solver is fully stable, the feature flag gates can be removed and this behavior can be the default.

[JohnnyMorganz]

Thanks for the PR! Looks mostly good to me

In addition, the nonstrict mode has been significantly improved, meaning #83 has been completely sidestepped

I don't think this is completely true. We are now going to trigger false positives again in the new type checker due to mismatched types. What we need to do is implement appropriate read/write types to the generated DataModel types. i.e., the read type should be the more expressive DM type, whilst the write type should be the generic Roblox type, allowing you to correctly read inst.Parent but write anything to it.

[JohnnyMorganz]

Also can you add some tests to Autocomplete.test.cpp for this?

You might be able to just re-use the existing tests, maybe switch them to use LUAU_BOTH_SOLVERS_TEST_CASE_FIXTURE so that they test with both solvers

[checkraisefold]

Thanks for the PR! Looks mostly good to me

In addition, the nonstrict mode has been significantly improved, meaning #83 has been completely sidestepped

I don't think this is completely true. We are now going to trigger false positives again in the new type checker due to mismatched types. What we need to do is implement appropriate read/write types to the generated DataModel types. i.e., the read type should be the more expressive DM type, whilst the write type should be the generic Roblox type, allowing you to correctly read inst.Parent but write anything to it.

I checked and it flat out does not work either way with both examples in #83, but in a different way. There's no warning at all, but the first argument of the connection is *error-type*. So it's actually correctly inferred in both cases and #83 is still side stepped, but a separate issue is causing this:

[JohnnyMorganz]

Also can you add some tests to Autocomplete.test.cpp for this?

Did you end up adding the DataModel types for the new solver? I don't see a test case for it

[checkraisefold]

All tests passing woohoo!!!!
🥳 🎉

[checkraisefold]

#806 is a blocker for new solver functionality until it's patched

[checkraisefold]

Do not merge - waiting on luau-lang/luau#1495 to remove the hacky mess workaround that is in here
Additionally waiting on luau-lang/luau#1493 to make the roblox def files actually, you know, work instead of being errortype spam, though this isn't a blocker for this PR

[checkraisefold]

The tests will fail because you had me split off the InlayHints fix and I feel like flat out turning off the tests is a bad idea

[JohnnyMorganz]

@checkraisefold Types smoketest is segfaulting, is this because of the flags? Ideally we don't crash even if the flags are not enabled

[JohnnyMorganz]

It actually seems related to the recent luau update to 0.651. Going to undo that sync for now

[JohnnyMorganz]

Thank you!