Update __init__.py with conversion of deprecated async_get_registry to async_get - bringing PR over from OG repo #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async_get_registry is deprecated and was removed in 2023.5.0. Converted use of the deprecated function to the replacement async_get
@nguilbault
Update init.py
580daad
@bdraco
bdraco commented on May 4, 2023
You also need to remove the await on this line
https://github.com/nguilbault/homeassistant_ecowitt/blob/[580daad](https://github.com/garbled1/homeassistant_ecowitt/pull/153/commits/580daadfa84e4206e2f1207d028e504c5a143b0f)fa84e4206e2f1207d028e504c5a143b0f/custom_components/ecowitt/__init__.py#L421
@nguilbault
Update init.py
46bf366
@nguilbault
Author
nguilbault commented on May 5, 2023
good catch - that's what I get for assuming that a function named async_get is actually async.
@mattdevo1
mattdevo1 commented on May 7, 2023 •
Thank you! Fixed my problem after upgrading to 2023.5. Although it looks like this project is dead at this point and there is an official Ecowitt integration now, so I guess I'll be migrating soon.
@rpajik
rpajik commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
@seidler2547 seidler2547 mentioned this pull request on May 9, 2023
garbled1#155
Open
@mattdevo1
mattdevo1 commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/
Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.
@rpajik
rpajik commented on May 9, 2023
@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(
The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/
Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.
Sorry, my fault. thx
@cheechm13 cheechm13 mentioned this pull request on May 25, 2023
elad-bar/ha-blueiris#208
Closed
@nliaudat
nliaudat commented on Jun 14, 2023
This repo is dead. Has anyone a good replacement or working fork ?
@mattdevo1
mattdevo1 commented on Jun 14, 2023
This repo is dead. Has anyone a good replacement or working fork ?
Have you tried the official integration?
https://www.home-assistant.io/integrations/ecowitt/
I haven't migrated yet. Would be interested to hear if it works for you.
@DMcGav
DMcGav commented on Jun 29, 2023
good catch - that's what I get for assuming that a function named async_get is actually async.
Thanks guys - great fix!