Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add willPunishExpenditureStaker field to colony motion #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakubcolony
Copy link
Collaborator

Small PR to unblock colonyCDapp#3322 which needs to be able to tell if a motion cancelling staked expenditure will also punish its creator or not.

Testing

  • Check out feat/cancel-exp-motion-field in CDapp and start your dev env as usual.
  • Install and enable Voting Reputation
  • Create an expenditure and progress it past the Review stage
  • From the three dot menu, select the cancel option
  • Select Reputation as decision method and try both cases: penalising and not penalising the expenditure creator

Run the following query to check the value of willPunishExpenditureStaker field:

query Motions {
  listColonyActions(filter: {type: {eq: CANCEL_EXPENDITURE_MOTION}}) {
    items {
      id
      motionData {
        willPunishExpenditureStaker
      }
    }
  }
}

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sensible. Good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants