Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use blockchain time for 'createdAt' field for stakes #330

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: use blockchain time for 'createdAt' field for stakes #330

merged 1 commit into from
Feb 6, 2025

Conversation

Nortsova
Copy link
Contributor

@Nortsova Nortsova commented Feb 3, 2025

In the UserHub, stakes were created with a real date instead of a blockchain date. So here is the fix for it 🙌

@Nortsova Nortsova mentioned this pull request Feb 4, 2025
Merged
iamsamgibbs
iamsamgibbs approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed alongside CDapp counterpart.

Makes sense we should be using block time here.

@Nortsova Nortsova force-pushed the fix/4074-stakes-created-at branch from e01173c to de36c36 Compare February 4, 2025 14:58
davecreaser
davecreaser approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, reviewed as part of CDapp PR ✅

rdig
rdig approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as part of JoinColony/colonyCDapp#4238

@Nortsova Nortsova merged commit 0b9580e into master Feb 6, 2025
1 check passed
@Nortsova Nortsova deleted the fix/4074-stakes-created-at branch February 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

@iamsamgibbs iamsamgibbs iamsamgibbs approved these changes

@davecreaser davecreaser davecreaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nortsova @rdig @iamsamgibbs @davecreaser