Fix: Expenditure createdIn domain should use fundedIn domain #4234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where it was impossible to fund a staked advanced payment via multi-sig if you had MS permissions in the sub-domain the payment was being funded from. This was due to a bug with how staked expenditures were created which were always being created in the root domain.
This PR ensures staked expenditures are created in the same domain they are funded from, which resolves the MS funding issue.
Testing
Diffs
Changes 🏗
createdIn
field for staked expenditures now uses from / team valueResolves #4165