Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expenditure createdIn domain should use fundedIn domain #4234

Conversation

iamsamgibbs
Copy link
Contributor

Description

This PR resolves an issue where it was impossible to fund a staked advanced payment via multi-sig if you had MS permissions in the sub-domain the payment was being funded from. This was due to a bug with how staked expenditures were created which were always being created in the root domain.

This PR ensures staked expenditures are created in the same domain they are funded from, which resolves the MS funding issue.

Testing

  • Step 1 - Install the multi-sig extension and assign Leela "Payer" multi-sig permissions in Andromeda.
  • Step 2 - Create an advanced payment using the staked decision method. Make sure you are funding from Andromeda.
  • Step 3 - Proceed through to the funding stage.
  • Step 4 - Fund the expenditure by selecting multi-sig from the select menu. The multi-sig motion should be created without issue.

Diffs

Changes 🏗

  • createdIn field for staked expenditures now uses from / team value

Resolves #4165

@iamsamgibbs iamsamgibbs self-assigned this Feb 3, 2025
@iamsamgibbs iamsamgibbs marked this pull request as ready for review February 3, 2025 13:33
@iamsamgibbs iamsamgibbs requested a review from a team as a code owner February 3, 2025 13:33
Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job figuring this one out @iamsamgibbs ! 💯 Can confirm I can fund from team Andromeda!

Screenshot 2025-02-03 at 14 38 27

leela-ms-funding

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here!

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice find and nice solution, gotta love modular helpers like this 💯
Gave leela Payer MS permissions in Andromeda
image
Created and avdanced payment with staking in Andromeda
image
Able to fund via multisig ✔️
image
Finalized and everything went through ✔️
image

Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @iamsamgibbs all looking good. Able to fund with multisig successfully:

Screenshot 2025-02-04 at 16 24 05 Screenshot 2025-02-04 at 16 24 58

@iamsamgibbs iamsamgibbs merged commit 9ee2b62 into master Feb 4, 2025
2 checks passed
@iamsamgibbs iamsamgibbs deleted the fix/4165-expenditure-createdin-domain-should-use-funding-domain branch February 4, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prod] Imposible to select Multi-sign method on Funding step
5 participants