Fix: Finalize button stuck in pending upon motion finalization

[mmioana]

Description

• The original issue is not reproducible anymore thanks to @rumzledz's awesome work in Fix: Do not needlessly show the Change Vote button #4149

Screen.Recording.2025-02-07.at.09.32.57.mov

• However, I found an issue where, if two users are quick enough to finalize a motion, only one will succeed. The less fortunate user will be left with a pending button that persists until the page is refreshed. This happens because the form remains in a submitting state even after the motion is finalized. This PR aims to address the issue.

Note

While the transaction will still fail for the unlucky user, they will now be able to continue with stake claiming if applicable

Testing

Note

It will be useful to have 2 browser windows opened, in one logged in as leela and the other as amy or fry

• Step 1. Please install the Reputation Weighted extension and enable it
• Step 2. Create a Mint tokens motion as leela using Reputation
• Step 3. Fully stake it and oppose to it
• Step 4. Switch to amy and vote for the motion. Now vote also as leela
• Step 5. Proceed to the Finalize step. Check both leela and amy see the Finalize button
• Step 6. Now you're going to be a bit fast, so Finalize the motion both as leela and amy
• Step 7. Check the Pending button is not getting stuck for any of the users and they can proceed to Claim.
  One of the users will still have the Pending transaction as finalising the motion will fail and the RetryProvider keeps re-trying it.
• Step 8. Claim the rewards where applicable and check there are no issues.

On this branch

Screen.Recording.2025-02-07.at.09.26.27.mov

Master

Screen.Recording.2025-02-07.at.09.29.04.mov

Diffs

New stuff ✨

• FinalizeStepContent to simplify a bit the code for the FinalizeStep

Resolves #4170

[bassgeta]

Nice work on this 😎
I would like to thank my ultrawide monitor for the speed ⏩

finalize-penderino.mp4

[Nortsova]

Amazing work!

I just did small fix to remove margin bottom for amy at claim block:

[iamsamgibbs]

Nice job, this is working nicely now!

Screen.Recording.2025-02-07.at.15.03.50.mov

And the padding was fixed after I did another pull: