Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reputation miner user experience #1160

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

chmanie
Copy link
Member

@chmanie chmanie commented Aug 30, 2023

This PR does the following:

  • Arguments to the reputation miner client executable are simplified and described better. Removed: network, localProviderAddress, localPort, providerAddress, all in favor of rpcEndpoint

  • Almost all arguments got sensible defaults. Now only privateKey or minerAddress have to be specified.

  • All arguments have corresponding environment variables with the REP_MINER prefix (e.g. privateKey is REP_MINER_PRIVATE_KEY)

  • The docker image got adjusted to that (and also should yield a more consistent build)

  • The whole configuration is shown when the reputation miner is started

  • All docs are adjusted to the new arguments and workflow

  • In the docs, the possibility to stake for reputation mining was added (directly from a form in the docs)

  • Alex fixed two issues that were related to first time miners.

@chmanie chmanie force-pushed the feature/rep-miner-ux branch from ee72c3c to 57ecf1d Compare August 30, 2023 14:44
@area
Copy link
Member

area commented Sep 13, 2023

The commit I've added pages the previous mining cycles on syncing. This is exactly the same issue that we were facing in the frontend in a few different areas that Raul fixed. The same solution is done here - instead of asking for all events in one big request, we split it up in to multiple requests and join all the responses together.

@chmanie chmanie force-pushed the feature/rep-miner-ux branch from 4a0de48 to b2c8515 Compare September 17, 2023 16:17
@chmanie chmanie force-pushed the feature/rep-miner-ux branch from cca9cd9 to 1e75b3f Compare September 18, 2023 11:24
@chmanie chmanie marked this pull request as ready for review September 18, 2023 11:27
@chmanie chmanie requested a review from area September 18, 2023 15:41
@area area added the on-hold label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants