Protect against non-parsable docs and missing teams

JoinColony · Jan 18, 2023 · 106e937 · 106e937
1 parent 69853a4
commit 106e937
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/examples/node/automation.ts b/examples/node/automation.ts
@@ -14,7 +14,7 @@ const start = async () => {
   const colonyNetwork = await ColonyNetwork.init(wallet);
   // Get an instance of your favourite colony
   const colony = await colonyNetwork.getColony(
-    '0x5D70776164466eB2985C5d49d9b535e4EAc95A2d',
+    '0x364B3153A24bb9ECa28B8c7aCeB15E3942eb4fc5',
   );
   // Mint 100 of the colony's native token
   await colony.mint(w`100`).metaTx();

diff --git a/src/ColonyNetwork/Colony.ts b/src/ColonyNetwork/Colony.ts
@@ -764,6 +764,12 @@ export class Colony {
       // eslint-disable-next-line max-len
       'moveFundsBetweenPots(uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256,address)',
       async () => {
+        const domain = await this.colonyClient.getDomain(toTeam);
+        if (domain.fundingPotId.isZero()) {
+          throw new Error(
+            `Team with id ${BigNumber.from(toTeam).toString()} does not exist`,
+          );
+        }
         // Manual permission proofs are needed here
         const [permissionDomainId, childSkillIndex] = await getPermissionProofs(
           this.colonyClient,

diff --git a/src/TxCreator/TxCreator.ts b/src/TxCreator/TxCreator.ts
@@ -6,6 +6,7 @@ import { MetadataValue } from '../ipfs';
 import { ParsedLogTransactionReceipt } from '../types';
 import { IPFS_METADATA_EVENTS } from '../ipfs/IpfsMetadata';
 import { ColonyNetwork } from '../ColonyNetwork';
+import { nonNullable } from '../utils';
 
 export interface TxConfig<M> {
   metadataType?: M;
@@ -157,9 +158,15 @@ export class TxCreator<
     const receipt = (await provider.waitForTransaction(
       parsed.data.txHash,
     )) as ParsedLogTransactionReceipt;
-    receipt.parsedLogs = receipt.logs.map((log) =>
-      this.contract.interface.parseLog(log),
-    );
+    receipt.parsedLogs = receipt.logs
+      .map((log) => {
+        try {
+          return this.contract.interface.parseLog(log);
+        } catch (e) {
+          return null;
+        }
+      })
+      .filter(nonNullable);
 
     return receipt;
   }