Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sk.json #152

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Create sk.json #152

merged 2 commits into from
Nov 10, 2023

Conversation

misa1515
Copy link
Contributor

No description provided.

@JonahKr
Copy link
Owner

JonahKr commented Oct 23, 2023

Hi @misa1515 👋
Thanks alot for your contribution!
I will probably work on some other issues for this card this week, and then will publish your additions into the next release.
Maybe in the meantime, you can consolidate them both into 1 PR?

Take care and stay safe! 👍

@misa1515
Copy link
Contributor Author

Hello @JonahKr
how can consoklidate both into 1PR?
Thank you.

@JonahKr
Copy link
Owner

JonahKr commented Oct 30, 2023

@misa1515 I would have to push to your fork.
Just checkout the patch-2 branch in your remote Repository and commit the change you did in #151
Then The change will be automatically reflected here.

@JonahKr JonahKr mentioned this pull request Nov 10, 2023
Closed
@JonahKr JonahKr merged commit f4de41b into JonahKr:master Nov 10, 2023
1 check passed
@JonahKr
Copy link
Owner

JonahKr commented Nov 10, 2023

Thanks for you contribution @misa1515 ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misa1515 @JonahKr