Teeny json suport

[alex-cova]

Removed @transient and java.desktop requirement, and created @JsonIgnore as replacement.

Usage:

String json = new TeenyJson().writeValueAsString(person);

[JonathanGiles]

Looks pretty good - just needs less TODOs and more JavaDoc :D

[alex-cova]

TeenyJson now can parse more complex JSONs like:

{
  "name": "Alex",
  "age": 25,
  "objectB": {
    "name": "Jonathan",
    "age": 30,
    "objectC": {
      "name": "John Doe",
      "age": 23
    }
  },
  "developer": true
}

ObjectA objectA = new TeenyJson()
                .readValue(json, ObjectA.class);

ObjectA.class

Also collections

List<ProductDto> products = new TeenyJson()
                .readList(json, ProductDto.class);

I should change readList to readCollection(json, List.class, ProductDto.class) to match the user collection.

[JonathanGiles]

This is largely equivalent to the getFieldName method above. I wonder if we could reduce the repetition?

[alex-cova]

I moved the repeated code to:

private static String findAlias(Map<String, Method> methodMap, String baseName, Class<?> type) {
        Method accessorMethod;

        if (type == boolean.class) {
            accessorMethod = methodMap.get("is" + baseName);
        } else {
            accessorMethod = methodMap.get("get" + baseName);
        }

        if (accessorMethod != null) {
            JsonAlias jsonAlias = accessorMethod.getAnnotation(JsonAlias.class);

            if (jsonAlias != null) {
                return jsonAlias.value();
            }
        }

        return null;
    }

[JonathanGiles]

Shouldn't the second parameter be Class<K extends Collection> collectionType?

[alex-cova]

Yes, but this may be the best choice:

public <T, K extends Collection> K readCollection(String json, Class<K> collectionType, Class<T> type)

[alex-cova]

Had to switch back to

public <T, K> K readCollection(String json, Class<? extends Collection> collectionType, Class<T> type) {

because this:

public <T, K extends Collection> K readCollection(String json, Class<K> collectionType, Class<T> type)

Raises a warning about unchecked assignment 😪

[JonathanGiles]

Nice addition!

[JonathanGiles]

Do you want this merged now, or do you want to keep working on it? We also need to update the readme.

[alex-cova]

Do you want this merged now, or do you want to keep working on it? We also need to update the readme.

uff I didn't realize that there are a lot of cases, there is a few cases missing especially with collections an Maps, I believe to have a decent version this week

[JonathanGiles]

Let me know when you want another review!

[alex-cova]

Let me know when you want another review!

Sorry for the late response, I've been sick these days. Yes please, another review would be awesome, I consider this PR can now be merged

[JonathanGiles]

I'm back! I've been travelling and busy with work / life. I'll get to reviewing this today.

[alex-cova]

I'm back! I've been travelling and busy with work / life. I'll get to reviewing this today.

Welcome back!, no problem I was also quite busy :P looking forward for new challenges

[JonathanGiles]

Only very minor feedback - then we can merge. Thanks