Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting environment variable in .scuba.yml #120

Merged
merged 12 commits into from
Sep 10, 2018

Conversation

JonathonReinhart
Copy link
Owner

Closes #88

@JonathonReinhart JonathonReinhart added this to the v2.3 milestone Sep 9, 2018
@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #120 into master will increase coverage by 0.08%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   94.87%   94.95%   +0.08%     
==========================================
  Files           9        9              
  Lines         566      595      +29     
==========================================
+ Hits          537      565      +28     
- Misses         29       30       +1
Impacted Files Coverage Δ
scuba/utils.py 100% <100%> (ø) ⬆️
scuba/__main__.py 96.72% <100%> (+0.01%) ⬆️
scuba/config.py 98.76% <96.87%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a5f67...a2f3332. Read the comment docs.

@JonathonReinhart
Copy link
Owner Author

@xanarin Would you care to review this?

Copy link
Collaborator

@xanarin xanarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in all of my target use cases 👍 However, there still appears to be an edge case that isn't handled properly.

scuba/config.py Outdated Show resolved Hide resolved
@JonathonReinhart JonathonReinhart merged commit 1bc33c7 into master Sep 10, 2018
@JonathonReinhart JonathonReinhart deleted the 88-scuba-yml-env-vars branch September 10, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants