-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting environment variable in .scuba.yml #120
Conversation
This simplifies mocking the OS environment
76a6919
to
b6ec1b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 94.87% 94.95% +0.08%
==========================================
Files 9 9
Lines 566 595 +29
==========================================
+ Hits 537 565 +28
- Misses 29 30 +1
Continue to review full report at Codecov.
|
65d0c4a
to
456144d
Compare
@xanarin Would you care to review this? |
2b0aa73
to
85d9904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in all of my target use cases 👍 However, there still appears to be an edge case that isn't handled properly.
...rather than 'None'
Closes #88