Ignore already existing UID/GIDs #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 9 9
Lines 616 616
=======================================
Hits 585 585
Misses 31 31Continue to review full report at Codecov.
|
JonathonReinhart
added a commit
that referenced
this pull request
Mar 5, 2020
JonathonReinhart
added a commit
that referenced
this pull request
Apr 5, 2020
Commit 254fc4a (#139) relaxed the checks for existing passwd entries matching the UID being added (and group, GID). This relaxes those checks even further by allowing existing entries which match both name *and* ID. We can't ignore the checks altogether because if we added a duplicate name with a different ID, the name would become ambiguous. The only real use case I can think of here is for "root" but I suppose there could be others, and this seems correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run a
nodecontainer like so...... I ran into the error message
scubainit: GID 1000 already exists in /etc/group.I guess the problem is that I am running locally as UID 1000, but the
nodepackages also come with anodeuser with that UID by default (see nodejs/docker-node#289).I think we could safely proceed in this case; Linux should be able to deal with multiple
/etc/passwd(and/etc/group, FWIW) entries pointing to the same numerical ID.Not sure if this solves #109, though.