scuba: Simplify ScubaDive.__str__ #246
Merged
+12
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 5 files 5 suites 1m 33s ⏱️ Results for commit 1afd9fb. ♻️ This comment has been updated with latest results. |
The output format is not particularly important; it is a diagnostic facility. Switch from complex custom formatting to pprint.pformat(). Note that we would like to use sort_dicts=False, but that was introduced in Python 3.8, and our current minimum is Python 3.7. See #242.
JonathonReinhart
force-pushed
the
simplify-ScubaDive-str
branch
from
c81b176 to
1afd9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output format is not particularly important; it is a diagnostic facility. Switch from complex custom formatting to pprint.pformat().