refactor: replace random int functions with Faker

This way, there should be less duplication.

Related to #83

apps/api/src/features/series/series.repository.ts

@@ -27,7 +27,6 @@ export const findOne = async ({
     )
     .$dynamic()
   if (episodeId) {
-    // TODO: Does this work?
     query = query
       .innerJoin(season, eq(series.id, season.seriesId))
       .innerJoin(episode, eq(season.id, episode.seasonId))

packages/core-db-factories/package.json

@@ -21,6 +21,7 @@
     "typescript": "^5.3.3"
   },
   "dependencies": {
+    "@faker-js/faker": "^8.4.0",
     "@serieslist/core-db": "workspace:*",
     "@serieslist/core-logger": "workspace:*",
     "fishery": "^2.2.2",

packages/core-db-factories/src/episode.factory.ts

@@ -1,10 +1,10 @@
+import { faker } from '@faker-js/faker'
 import { episode, type Episode } from '@serieslist/core-db'
 import { Factory } from 'fishery'
 import { nanoid } from 'nanoid'
 
 import { db } from './lib/db'
 import { seasonFactory } from './season.factory'
-import { generateRandomInt } from './utils/generateRandomInt'
 
 export const episodeFactory = Factory.define<Episode>(
   ({ sequence, onCreate, params }) => {
@@ -22,7 +22,7 @@ export const episodeFactory = Factory.define<Episode>(
 
     return {
       id: sequence,
-      tmdbId: generateRandomInt(1, 9999999),
+      tmdbId: faker.number.int(9999999),
       title: 'Test Episode',
       imdbId: `tt${nanoid(12)}`,
       number: sequence,

packages/core-db-factories/src/season.factory.ts

@@ -1,9 +1,9 @@
+import { faker } from '@faker-js/faker'
 import { season, type Season } from '@serieslist/core-db'
 import { Factory } from 'fishery'
 
 import { db } from './lib/db'
 import { seriesFactory } from './series.factory'
-import { generateRandomInt } from './utils/generateRandomInt'
 
 export const seasonFactory = Factory.define<Season>(
   ({ sequence, onCreate, params }) => {
@@ -21,7 +21,7 @@ export const seasonFactory = Factory.define<Season>(
 
     return {
       id: sequence,
-      tmdbId: generateRandomInt(1, 9999999),
+      tmdbId: faker.number.int(9999999),
       title: `Season ${sequence}`,
       number: sequence,
       seriesId: params.seriesId ?? seriesFactory.build().id,

packages/core-db-factories/src/series.factory.ts

@@ -1,11 +1,11 @@
+import { faker } from '@faker-js/faker'
 import { series } from '@serieslist/core-db'
 import type { Episode, Season, Series } from '@serieslist/core-db'
 import { Factory } from 'fishery'
 import { nanoid } from 'nanoid'
 
 import { createArrayOfLength } from './lib/createArrayOfLength'
 import { db } from './lib/db'
-import { generateRandomInt } from './utils/generateRandomInt'
 
 import { episodeFactory, seasonFactory } from '.'
 
@@ -21,7 +21,7 @@ export const seriesFactory = Factory.define<Series>(
 
     return {
       id: sequence,
-      tmdbId: generateRandomInt(1, 9999999),
+      tmdbId: faker.number.int(9999999),
       imdbId: `tt${nanoid(12)}`,
       title: 'Testing Series',
       startYear: 2020,

packages/feature-tmdb/package.json

@@ -26,6 +26,7 @@
     "zod": "^3.22.3"
   },
   "devDependencies": {
+    "@faker-js/faker": "^8.4.0",
     "@serieslist/eslint-config-base": "workspace:*",
     "@serieslist/prettier-config": "workspace:*",
     "@serieslist/typescript-config-base": "workspace:*",

packages/feature-tmdb/src/tmdbSeriesDetails.factory.ts

@@ -1,3 +1,4 @@
+import { faker } from '@faker-js/faker'
 import { subDays } from 'date-fns'
 import { Factory } from 'fishery'
 import { nanoid } from 'nanoid'
@@ -6,12 +7,8 @@ import type { z } from 'zod'
 import type { TMDBSeason, TMDBEpisode, TMDBSeries } from './tmdb.types'
 import type { tmdbNotFoundSchema } from './tmdbRequests.schema'
 
-const generateRandomInt = (min: number, max: number) => {
-  return Math.floor(Math.random() * (max - min + 1) + min)
-}
-
 export const tmdbSeriesDetailsFactory = Factory.define<TMDBSeries>(() => ({
-  id: generateRandomInt(1, 9999999),
+  id: faker.number.int(9999999),
   name: 'Test Series',
   poster_path: 'foo.jpg',
   overview: 'Test plot.',
@@ -30,7 +27,7 @@ export const tmdbSeriesDetailsFactory = Factory.define<TMDBSeries>(() => ({
 
 export const tmdbEpisodeFactory = Factory.define<TMDBEpisode>(
   ({ sequence }) => ({
-    id: generateRandomInt(1, 9999999),
+    id: faker.number.int(9999999),
     episode_number: sequence,
     name: 'Test Episode',
     air_date: subDays(new Date(Date.now()), 2),
@@ -39,7 +36,7 @@ export const tmdbEpisodeFactory = Factory.define<TMDBEpisode>(
 
 export const tmdbSeasonFactory = Factory.define<TMDBSeason>(
   ({ sequence, params }) => ({
-    id: generateRandomInt(1, 9999999),
+    id: faker.number.int(9999999),
     season_number: sequence,
     name: `Season ${params.season_number ?? sequence}`,
     air_date: new Date(Date.now()),