Safely access metadata #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a key is missing from info.json, it shouldn't prevent the rest of the data from being loaded. When adding an item that wasn't a part of a playlist, there will be no 'playlist_title'. Before this change, all the metadata would be missing from these videos. Now, the other data gets loaded. Yay! I tried to replecate the pattern already established of using: ``` if data['key']: ``` but this raised the same KeyError when the key didn't exist. I'm not a regular Python dev but I think something changed in Python 3. Using the `in` syntax here seems to work great for all the places I changed. I think this should address: #6 (comment) #10 (comment) #12 As the issue they describe has the same symptoms that I was experiencing.
|
Thank you for taking the time to look into the issue and making a pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a key is missing from info.json, it shouldn't prevent the rest of
the data from being loaded.
When adding an item that wasn't a part of a playlist, there will be no
'playlist_title'. Before this change, all the metadata would be missing
from these videos. Now, the other data gets loaded. Yay!
I tried to replecate the pattern already established of using:
but this raised the same KeyError when the key didn't exist. I'm not a
regular Python dev but I think something changed in Python 3. Using the
insyntax here seems to work great for all the places I changed.I think this should address:
#6 (comment)
#10 (comment)
#12
As the issue they describe has the same symptoms that I was
experiencing.