Speed up Python testing #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18
Before, every
IntegerTestDataandFloatTestDataopened up a new Python program and sent one value to it. Every new test opened another Python instance. Now, we only run two Python instances, one forIntegerTestDataand one forFloatTestData. For each test data type, we take all test data and serialize it into json, pass it to Python, process the values, serialize the results, and return them. With 420 tests, tests would take 4+ seconds to run, now, tests run in the sub 100 ms range (~1.75% the original time) and shouldn't grow noticeably over time.The work this PR also opens up the door for us to map Python error type, within the python program, to an error type we can understand in Gleam, and then assert that our error matches theirs, via some mapping of ours to theirs.
See #55
Need to do a little bit of clean up to make this mergeable, but feeling good. 💪