Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppressTypeErrors: do not add full path to ts-expect-error comment #1525

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

Instead of adding the full file path to the ts-expect-error TODO comment, the start of the path will be replaced with . It's not helpful to add the full path since that will differ from computer to computer. These comments will probably be committed to project repo and multiple users will be reading them. It is more useful to refer them as relative to the project root.

I have added tests to demonstrate this.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (e484ffc) to head (9d9fc04).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
+ Coverage   78.62%   78.66%   +0.04%     
==========================================
  Files         175      175              
  Lines       10957    10979      +22     
  Branches     1021     1024       +3     
==========================================
+ Hits         8615     8637      +22     
  Misses       2338     2338              
  Partials        4        4              
Flag Coverage Δ
mutation 73.30% <100.00%> (+0.05%) ⬆️
unit 28.33% <12.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiesonthesky
Copy link
Collaborator Author

rubiesonthesky commented Apr 4, 2024

Codecov, I can literally see that the code is run by the test because otherwise we would not get that output.

dog shaking head in disapproval

This comment was marked as outdated.

@rubiesonthesky
Copy link
Collaborator Author

rubiesonthesky commented Apr 7, 2024

Closed in favor of #1542

@rubiesonthesky rubiesonthesky deleted the suppressTypeErrors-remove-full-path branch April 7, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant