Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary part in callback condition #115

Merged
merged 1 commit into from
May 29, 2024

Conversation

JoshuaLampert
Copy link
Owner

See trixi-framework/Trixi.jl#1960. This part of the condition is always true and thus unnecessary.

@JoshuaLampert JoshuaLampert requested a review from ranocha May 28, 2024 19:42
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.83%. Comparing base (526c112) to head (501f23c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          17       17           
  Lines        1234     1234           
=======================================
  Hits         1195     1195           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha merged commit a7eb130 into main May 29, 2024
14 checks passed
@JoshuaLampert JoshuaLampert deleted the cleanup-condition-callback branch May 29, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants