Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare publication #137

Merged
merged 13 commits into from
Aug 18, 2024
Merged

prepare publication #137

merged 13 commits into from
Aug 18, 2024

Conversation

ranocha
Copy link
Collaborator

@ranocha ranocha commented Aug 16, 2024

Since we're adding more features to this repo, it's getting more interest from others. Thus, it would be nice to polish it a bit - so that we can also prepare a software paper in the future. I have started this process in this PR.

@JoshuaLampert If you're fine with this, could you maybe list some breaking changes in the NEWS.md file?

@ranocha ranocha requested a review from JoshuaLampert August 16, 2024 17:29
@JoshuaLampert
Copy link
Owner

Thanks a lot for initiating that! I will fill the NEWS.md file with the changes from the last releases.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (935081c) to head (1a3aa96).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          20       20           
  Lines        1569     1569           
=======================================
  Hits         1531     1531           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Owner

@JoshuaLampert If you're fine with this, could you maybe list some breaking changes in the NEWS.md file?

I filled the NEWS.md file. Please have a look if this looks fine to you.

Copy link
Collaborator Author

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@ranocha
Copy link
Collaborator Author

ranocha commented Aug 17, 2024

Let's see how the rendered changelog looks in the docs. If it's fine, I'm fine merging this PR

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Owner

The changelog looks nice, I think.

@ranocha
Copy link
Collaborator Author

ranocha commented Aug 18, 2024

I adapted the text in the code of conduct so that the links are better integrated in the markdown text.

@ranocha
Copy link
Collaborator Author

ranocha commented Aug 18, 2024

The changelog looks nice, I think.

I agree - nice work 👍

Copy link
Owner

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@JoshuaLampert JoshuaLampert merged commit 1d821a7 into main Aug 18, 2024
15 checks passed
@JoshuaLampert JoshuaLampert deleted the hr/prepare_publication branch August 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants