Print timer of SummaryCallback in finalizer

[JoshuaLampert]

This way the timer of the summary callback is printed at the end of the simulation and not at the end of the last timestep.

[ranocha]

Thanks! I think

DispersiveShallowWater.jl/test/test_unit.jl

Line 221 in 492f918

@test_nowarn summary_callback()

needs to be updated as well.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (492f918) 96.16% compared to head (b3ea701) 96.07%.

Files	Patch %	Lines
src/callbacks_step/summary.jl	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   96.16%   96.07%   -0.10%     
==========================================
  Files          16       17       +1     
  Lines        1095     1095              
==========================================
- Hits         1053     1052       -1     
- Misses         42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaLampert]

Newer versions of OrdinaryDiffEq.jl (including v6.59.3, which is needed for the finalize function to work) require Julia v1.9. Thus, the tests use Julia v1.9, now.

[ranocha]

If you update the IC tests to Julia v1.9, you should also update the Julia requirement in

DispersiveShallowWater.jl/Project.toml

Line 37 in 492f918

julia = "1.8"

[JoshuaLampert]

Done in 1107493

[JoshuaLampert]

If you update the IC tests to Julia v1.9, you should also update the Julia requirement

This is not the case for Trixi.jl. Should this be adapted there, too?

[ranocha]

Sorry, I was too fast. There are other references to v1.8 of Julia, e.g.

DispersiveShallowWater.jl/README.md

Line 26 in 492f918

DispersiveShallowWater.jl works with Julia v1.8 and newer. DispersiveShallowWater.jl is a registered Julia package. Therefore, you can install it by executing the following commands from the Julia REPL

[ranocha]

If you update the IC tests to Julia v1.9, you should also update the Julia requirement

This is not the case for Trixi.jl. Should this be adapted there, too?

No, we explicitly keep some tests with Julia v1.8 in the Trixi.jl repo

https://github.com/trixi-framework/Trixi.jl/blob/b5d0a50214abb9b33dc4a4859a4a12c6e3149cb1/.github/workflows/ci.yml#L83-L86

[JoshuaLampert]

Ah ok, thanks!

[JoshuaLampert]

Sorry, I was too fast. There are other references to v1.8 of Julia, e.g.

Done in b3ea701 and thanks for the hint.

[ranocha]

Thanks!