[Origo] Adds support to mark storage-node/distrubtion-node under maintenance #4793
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| declare module 'inquirer-datepicker' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { | ||
| INodeOperationalStatusMetadata, | ||
| ISetNodeOperationalStatus, | ||
| NodeOperationalStatusMetadata, | ||
| SetNodeOperationalStatus, | ||
| } from '@joystream/metadata-protobuf' | ||
| import AccountsCommandBase from '../../command-base/accounts' | ||
| import DefaultCommandBase, { flags } from '../../command-base/default' | ||
| import { NODE_OPERATIONAL_STATUS_OPTIONS, NodeOperationalStatus } from '../../types/metadata' | ||
|
|
||
| export default class LeadSetNodeOperationalStatus extends AccountsCommandBase { | ||
| static description = `Set/update distribution node operational status. Requires distribution working group leader permissions.` | ||
|
|
||
| static flags = { | ||
| bucketId: flags.bucketId({ | ||
| required: true, | ||
| }), | ||
| workerId: flags.integer({ | ||
|
There was a problem hiding this comment. I suggested that worker id is not needed in metadata. If we agree on that, then this workerId can be dropped. There was a problem hiding this comment. Please see #4793 (comment) |
||
| char: 'w', | ||
| description: 'ID of the operator (distribution group worker)', | ||
| required: true, | ||
| }), | ||
| operationalStatus: flags.enum<NodeOperationalStatus>({ | ||
| char: 'o', | ||
| options: [...NODE_OPERATIONAL_STATUS_OPTIONS], | ||
| required: false, | ||
| description: 'Operational status of the operator', | ||
| }), | ||
| ...DefaultCommandBase.flags, | ||
| } | ||
|
|
||
| async run(): Promise<void> { | ||
| const { bucketId, workerId, operationalStatus: statusType } = this.parse(LeadSetNodeOperationalStatus).flags | ||
| const leadKey = await this.getDistributorLeadKey() | ||
|
|
||
| let operationalStatus: INodeOperationalStatusMetadata = {} | ||
| switch (statusType) { | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. It makes more sense to make it required, the command name doesn't imply what the default value should be. There was a problem hiding this comment.
Done |
||
| case 'Normal': { | ||
| operationalStatus = { status: NodeOperationalStatusMetadata.OperationalStatus.NORMAL } | ||
| break | ||
| } | ||
| case 'NoService': { | ||
| operationalStatus = { status: NodeOperationalStatusMetadata.OperationalStatus.NO_SERVICE } | ||
| break | ||
| } | ||
| case 'NoServiceFrom': { | ||
| operationalStatus = { | ||
| status: NodeOperationalStatusMetadata.OperationalStatus.NO_SERVICE, | ||
| noServiceFrom: (await this.datePrompt({ message: 'Enter No Service period start date' })).toISOString(), | ||
| } | ||
| break | ||
| } | ||
| case 'NoServiceDuring': { | ||
| operationalStatus = { | ||
| status: NodeOperationalStatusMetadata.OperationalStatus.NO_SERVICE, | ||
| noServiceFrom: (await this.datePrompt({ message: 'Enter No Service period start date' })).toISOString(), | ||
| noServiceTo: (await this.datePrompt({ message: 'Enter No Service period end date' })).toISOString(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| this.log(`Setting node operational status...`, { | ||
| bucketId: bucketId.toHuman(), | ||
| workerId, | ||
| operationalStatus, | ||
| }) | ||
|
|
||
| const metadata: ISetNodeOperationalStatus = { | ||
| workerId: workerId.toString(), | ||
| bucketId: `${bucketId.distributionBucketFamilyId}:${bucketId.distributionBucketIndex}`, | ||
| operationalStatus, | ||
| } | ||
| await this.sendAndFollowTx( | ||
| await this.getDecodedPair(leadKey), | ||
| this.api.tx.distributionWorkingGroup.leadRemark( | ||
| '0x' + Buffer.from(SetNodeOperationalStatus.encode(metadata).finish()).toString('hex') | ||
| ) | ||
| ) | ||
| this.log('Bucket operator metadata successfully set/updated!') | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,7 +93,7 @@ query getDistributionBucketsWithBagsByIds($ids: [String!]) { | |
| } | ||
| } | ||
|
|
||
| query getDistributionBucketsWithBagsByWorkerId($workerId: BigInt!) { | ||
| distributionBuckets(where: { operators_some: { workerId_eq: $workerId, status_eq: ACTIVE } }) { | ||
| ...DistributionBucketWithBags | ||
| } | ||
|
|
@@ -107,7 +107,17 @@ fragment StorageBucketOperatorFields on StorageBucket { | |
| } | ||
|
|
||
| query getActiveStorageBucketOperatorsData { | ||
| storageBuckets( | ||
| where: { | ||
| operatorStatus: { isTypeOf_eq: "StorageBucketOperatorStatusActive" } | ||
| operatorMetadata: { | ||
| OR: [ | ||
| { nodeOperationalStatus_isNull: true } | ||
| { nodeOperationalStatus: { isTypeOf_eq: "NodeOperationalStatusNormal" } } | ||
|
There was a problem hiding this comment. This filter would skip any nodes with future maintenance as well. We probably should get all the operators and later only filter those that are under maintenance currently There was a problem hiding this comment. Done in 0537ee7 |
||
| ] | ||
| } | ||
| } | ||
| ) { | ||
| ...StorageBucketOperatorFields | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the date picker, works really nicely in the terminal!
Perhaps a more reasonable default would be the current date
new Date().toISOString(), so less fiddling with inital year and month for the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done